Project

General

Profile

Support #3474

Symbol in PDF invoice

Added by Joost mag about 5 years ago. Updated about 5 years ago.

Status:
Closed
Priority:
Normal
Target version:
Start date:
09/26/2016
Due date:
% Done:

50%

Estimated time:
2.00 h
Invoice time (hours):
2.00

Description

Hi,

We don't show the currency symbol on the frontend. But it's also been removed in the PDF invoice (We use PDF Customizer from Fooman).

Regards,
Joost

Schermafbeelding 2016-09-27 om 09.06.53.png View (21.1 KB) Joost mag, 09/27/2016 09:07 AM

Schermafbeelding 2016-09-27 om 09.03.44.png View (181 KB) Joost mag, 09/27/2016 09:07 AM

Schermafbeelding 2016-10-03 om 15.23.18.png View (29.3 KB) Joost mag, 10/03/2016 03:23 PM

History

#1 Updated by Jurij Nikolajev about 5 years ago

  • Status changed from New to Additional info required

Please, provide additional information:
1. Magento version
2. Extension version
3. Extension settings (screenshots)
4. Issue description (what you want to achive, what you get, how to reproduce) - screenshots
5. If you use 3rd party extensions, try to disable those and make sure that issue is not in this 3rd party extension

#2 Updated by Joost mag about 5 years ago

Jurij Nikolajev wrote:

Please, provide additional information:
1. Magento version
2. Extension version
3. Extension settings (screenshots)
4. Issue description (what you want to achive, what you get, how to reproduce) - screenshots
5. If you use 3rd party extensions, try to disable those and make sure that issue is not in this 3rd party extension

1. Magento version: 1.9.2.4
2. Extension version: 1.2.6
3. See screenshot.
4. I disabled showing the currency. So € 10 became 10. But i don't want to remove the symbol (€) in the PDF invoice. Now it's also removed in the PDF invoice.
5. We use fooman PDF invoice.

#3 Updated by Jurij Nikolajev about 5 years ago

  • Status changed from Additional info required to Results approval pending
  • Assignee set to Jurij Nikolajev
  • Target version set to ver. 1.2.6
  • % Done changed from 0 to 50

I think this extension (fooman PDF invoice) uses own controller and our extension does not exclude its options for this controller.
You can tell Currency Manager extension that Fooman extension should be excluded.
you can write small extension for this or change Currency Manager sorce code.

Additional information you can get at extension changelog for version 1.2.2 (https://shop.etwebsolutions.com/eng/et-currency-manager.html?___from_store=rus#changelog).

You can check other tickets: #2108, #1814

#4 Updated by Joost mag about 5 years ago

Jurij Nikolajev wrote:

I think this extension (fooman PDF invoice) uses own controller and our extension does not exclude its options for this controller.
You can tell Currency Manager extension that Fooman extension should be excluded.
you can write small extension for this or change Currency Manager sorce code.

Additional information you can get at extension changelog for version 1.2.2 (https://shop.etwebsolutions.com/eng/et-currency-manager.html?___from_store=rus#changelog).

You can check other tickets: #2108, #1814

Thank you. I found the following code;

    public function isInOrder()
    {
        $moduleName = Mage::app()->getRequest()->getModuleName();
        $controllerName = Mage::app()->getRequest()->getControllerName();

        $orderModules = array('sales', 'checkout', 'paypal');
        $modifiedOrderModules = array(
            'order_modules' => new Varien_Object(array('module_names'=>$orderModules)),
        );

        Mage::dispatchEvent('et_currencymanager_checking_is_in_order_before', $modifiedOrderModules);

        $orderModules = $modifiedOrderModules['order_modules']->getData('module_names');

        return ((in_array($moduleName, $orderModules))
            || (
                ($moduleName == 'admin') && (strpos($controllerName, 'sales_order') !== false)
            ));
    }

I see you exclude the sales/checkout in the frontend. Are you mean for sales the orders in my account? That's not working, also when i add onestepcheckout it's not working for that module on the frontend.

#5 Updated by Jurij Nikolajev about 5 years ago

What is the name of the extension in Magento code? What have you tryed to add?

Standard extension names that are excluded are

$orderModules = array('sales', 'checkout', 'paypal');

You should find extension name and add it to exceptions
  • in this function (you will loose those changes after extension upgrade)
  • in external extension

#6 Updated by Joost mag about 5 years ago

Jurij Nikolajev wrote:

What is the name of the extension in Magento code? What have you tryed to add?

Standard extension names that are excluded are
[...]

You should find extension name and add it to exceptions
  • in this function (you will loose those changes after extension upgrade)
  • in external extension

I changed PayPal to onestepcheckout. But also sales is not working. The price symbol is also removed in account -> my orders.

#7 Updated by Jurij Nikolajev about 5 years ago

Cannot help you without additional information.
You chould check what extension name is used for comparsion in this part of code. Maybe your extension name is "opc" or "one-step" or different. And invoice genereting can be prepared in other extension, in this case you should addd additional extension name there.

Add log writing to this part of code and check in log file all extension names, that use currency formatting function. Maybe you can find neccessary in this list

$message = 'module: ' $moduleName . ' - controller: ' . $controllerName;
Mage::log($message, Zend_Log::DEBUG, 'my_debug.log', true);

If you have troubles to find it out and modify your store, you can hire any developer to help you, providing them information from this ticket.

Our team can analyze your store and make necessary changes for you, but only on payd basis.
Our rates are available here: https://shop.etwebsolutions.com/eng/our-services/ (2 hours will be enought for this work, but our minimal order is 4 hours for standard rate).

#8 Updated by Joost mag about 5 years ago

Jurij Nikolajev wrote:

Cannot help you without additional information.
You chould check what extension name is used for comparsion in this part of code. Maybe your extension name is "opc" or "one-step" or different. And invoice genereting can be prepared in other extension, in this case you should addd additional extension name there.

Add log writing to this part of code and check in log file all extension names, that use currency formatting function. Maybe you can find neccessary in this list
[...]

If you have troubles to find it out and modify your store, you can hire any developer to help you, providing them information from this ticket.

Our team can analyze your store and make necessary changes for you, but only on payd basis.
Our rates are available here: https://shop.etwebsolutions.com/eng/our-services/ (2 hours will be enought for this work, but our minimal order is 4 hours for standard rate).

I understand about that module name. But why is "sales" not working? This is default in the module;

See attached screenshot of my orders in the frontend for the customer.

#9 Updated by Jurij Nikolajev about 5 years ago

I do not understand how you see that "sales" does not work. Have you checked that sales extension is used in comparsion in your case? Maybe some 3rd party extension is used and there is no sales extension appear.

It is very hard to provide you any help withot full information what happens.
It is faster to check in your store code by myself, but we do not have enought time to analyze all our free extension users stores.

#10 Updated by Alexey Yerofeyev about 5 years ago

  • Estimated time set to 2.00 h
  • Invoice time (hours) set to 2.00

#11 Updated by Alexey Yerofeyev about 5 years ago

  • Status changed from Results approval pending to Closed

Also available in: Atom PDF